Music Notation

tests/test_musicxml.py

@@ -48,7 +48,7 @@ class MusicXMLTests(unittest.TestCase):
     self.assertEqual(len(sources), 6)
     for path in sources:
       with self.subTest(path=path):
-        self.assertEqual(load_musicxml(path)['schema_version'], 2)
+        self.assertEqual(load_musicxml(path)['schema_version'], 3)
   def test_all_written_values_and_dots(self):
     for kind in NOTE_TYPES:
       for dots in (0, 1, 2, 3):
@@ -63,7 +63,7 @@ class MusicXMLTests(unittest.TestCase):
   def test_doctype_allowed_but_entities_rejected(self):
     source = xml_score(xml_note())
     source = source.replace('<score-partwise', '<!DOCTYPE score-partwise SYSTEM "https://invalid.test/partwise.dtd"><score-partwise', 1)
-    self.assertEqual(parse(source)['schema_version'], 2)
+    self.assertEqual(parse(source)['schema_version'], 3)
     malicious = xml_score(xml_note()).replace('<score-partwise', '<!DOCTYPE score-partwise [<!ENTITY secret SYSTEM "file:///etc/passwd">]><score-partwise', 1)
     with self.assertRaises(MusicXMLError):
       parse(malicious)
@@ -137,11 +137,10 @@ class MusicXMLTests(unittest.TestCase):
     for extra in extras:
       with self.subTest(extra=extra), self.assertRaises(MusicXMLError):
         parse(xml_score(xml_note(extra=extra)))
-    for extra in ('<barline><repeat direction="backward"/></barline>', '<backup><duration>4</duration></backup>', '<direction><direction-type><dynamics><ff/></dynamics></direction-type></direction>'):
+    for extra in ('<barline><repeat direction="backward"/></barline>', '<backup><duration>5</duration></backup>', '<direction><direction-type><dynamics><ff/></dynamics></direction-type></direction>'):
       with self.subTest(extra=extra), self.assertRaises(MusicXMLError):
         parse(xml_score(xml_note() + extra))
-    with self.assertRaises(MusicXMLError):
-      parse(xml_score(xml_note(alter='0.5')))
+    self.assertEqual(fraction(notes(parse(xml_score(xml_note(alter='0.5'))))[0]['pitches'][0]['alter']), Fraction(1, 2))
     with self.assertRaises(MusicXMLError):
       parse(xml_score(xml_note(extra='<tie type="stop"/>')))
     with self.assertRaises(MusicXMLError):